Diskuv.OCaml 1.1.0

[jonahbeckford]

• [Y] Have you signed the Contributor License Agreement?
• [Y] Have you checked that there aren't other open pull requests for the same manifest update/change?
• [Y] Have you validated your manifest locally with winget validate --manifest <path>?
• [Y] Have you tested your manifest locally with winget install --manifest <path>?
• [Y] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

---

Microsoft Reviewers: Open in CodeFlow

[wingetbot]

   

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @jonahbeckford,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @jonahbeckford,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @jonahbeckford,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @jonahbeckford,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

[stephengillie]

Now I am super confused. Those lines are the last lines of a successful install.

I opened a new window in the VM, and with this was able to launch all programs and perform a Defender scan, completing a manual validation.

The issue here is that the Windows Path in the registry is being updated, but the $env:PATH of the current window isn't. So Validation (running from the same window) gets errors when running executables and links. This is also seen when Git and other path-based applications are installed as dependencies:

• [Dependency Issue]: Dependency can't be found by main installer after it's installed winget-cli#2939

This is based off the current console window's $env:PATH variable:

C:\Windows\system32;
C:\Windows;
C:\Windows\System32\Wbem;
C:\Windows\System32\WindowsPowerShell\v1.0;
C:\Windows\System32\OpenSSH;
C:\Users\user\AppData\Local\Microsoft\WindowsApps

Compared to the $env:PATH variable of the new window:

C:\Windows\system32;
C:\Windows;
C:\Windows\System32\Wbem;
C:\Windows\System32\WindowsPowerShell\v1.0;
C:\Windows\System32\OpenSSH;
C:\Program Files\Git\cmd;
C:\Users\user\AppData\Local\Programs\DISKUV~1\bin;
C:\Users\user\AppData\Local\Programs\DISKUV~1\usr\bin;
C:\Users\user\AppData\Local\Microsoft\WindowsApps

Unfortunately I don't have access to the validation pipeline to run winget info.

[jonahbeckford]

The issue here is that the Windows Path in the registry is being updated, but the $env:PATH of the current window isn't. So Validation (running from the same window) gets errors when running executables and links.

Interesting. I suppose I could inject the PATH updates into the current window ... that would take a bit of development but is doable. But I'm not sure it is right; injecting environment variables is quite a hacky thing to do!

Question 1: Do you suggest I inject the PATH updates? (If yes, it would be more robust if the --pid of the winget current window was passed to the installer switch. Not strictly necessary though.)

I'm also not setting the Git.Git dependency (and Visual Studio Build Tools) in the manifest because I saw all the warnings that dependencies are not used in winget.

Question 2: Should I model the dependencies in the manifest?

[stephengillie]

Injecting PATH updates might be a bit excessive. It should be possible to change the validation pipeline to install in one window and open a new window for testing. Basically, automate the process described above. But feel free if you really want to. 😁

Winget currently installs the first listed dependency. Hopefully additional dependencies will be supported soon. With this package's numerous dependencies, it might be more streamlined to keep the current arrangement.

[ghost]

Hello @stephengillie!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

jonahbeckford,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

[ghost]

Hello jonahbeckford,
Validation has completed.

Template: msftbot/validationCompleted

[wingetbot]

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.