Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: GitHub.GitLFS version 3.3.0 #90133

Merged

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Nov 30, 2022

Result: Installation Successful

Manifest Add/Remove Programs
Name Git LFS Git LFS version 3.3.0
Version 3.3.0 3.3.0
Publisher GitHub, Inc. GitHub, Inc.
ProductCode {286391DE-F778-44EA-9375-1B21AAA04FF0}_is1

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 4249

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jedieaston
jedieaston previously approved these changes Nov 30, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 30, 2022
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 30, 2022
@ghost ghost assigned vedantmgoyal9 Nov 30, 2022
@ghost
Copy link

ghost commented Nov 30, 2022

Hello @vedantmgoyal2009,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 30, 2022
@ghost ghost assigned stephengillie and ryfu-msft Nov 30, 2022
@stephengillie
Copy link
Collaborator

stephengillie commented Nov 30, 2022

Git is a dependency, apparently. Is there a flavor of Git already in Winget that would work in this scenario?
image

Edit: Found Git.Git, and tested with this package as a dependency, but the installer still ended in the same error. Does the Git location need to be specified in an installer flag?

@stephengillie
Copy link
Collaborator

Found a possible cause: It appears that the GitLFS installer finds Git via Windows Path. A PowerShell window's $env:path variable, and the PATH variable in a Command Prompt window, aren't updated while it's running - normally only at launch. I was able to complete installing this package in a VM by installing it with Winget, accepting the error, closing and reopening either PowerShell or a Command Prompt, then installing the package with Winget again. This should be an issue regarding dependencies and/or maybe how Winget handles the Windows Path - I'll look into reporting it.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Dec 9, 2022
@ghost
Copy link

ghost commented Dec 9, 2022

Hello @vedantmgoyal2009,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Dec 9, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 9, 2022
@ghost
Copy link

ghost commented Dec 10, 2022

Hello vedantmgoyal2009,
Validation has completed.

Template: msftbot/validationCompleted

@ghost
Copy link

ghost commented Dec 10, 2022

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Dec 10, 2022
@ghost
Copy link

ghost commented Dec 10, 2022

Hello vedantmgoyal2009,
Validation has completed.

Template: msftbot/validationCompleted

@ghost
Copy link

ghost commented Dec 10, 2022

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Dec 10, 2022
@ghost
Copy link

ghost commented Dec 10, 2022

Hello vedantmgoyal2009,
Validation has completed.

Template: msftbot/validationCompleted

@ghost
Copy link

ghost commented Dec 10, 2022

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Dec 10, 2022
@ghost
Copy link

ghost commented Dec 10, 2022

Hello vedantmgoyal2009,
Validation has completed.

Template: msftbot/validationCompleted

@ghost
Copy link

ghost commented Dec 10, 2022

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

@stephengillie
Copy link
Collaborator

/azp run

@ghost ghost removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Dec 12, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 12, 2022
@ghost
Copy link

ghost commented Dec 12, 2022

Hello vedantmgoyal2009,
Validation has completed.

Template: msftbot/validationCompleted

@ghost
Copy link

ghost commented Dec 12, 2022

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

@stephengillie stephengillie merged commit 6e7f87f into microsoft:master Dec 12, 2022
@stephengillie stephengillie deleted the GitHub.GitLFS-3.3.0-4874BEA77C0DD branch December 12, 2022 17:45
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Unattended-Failed We've waived "Validation-Unsattended-Failed" it was likely a false detection.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants