Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub.GitCredentialManager version 2.0.877.50119 #90517

Closed
wants to merge 1 commit into from
Closed

GitHub.GitCredentialManager version 2.0.877.50119 #90517

wants to merge 1 commit into from

Conversation

zejjnt
Copy link

@zejjnt zejjnt commented Dec 3, 2022 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Dec 3, 2022
@ghost ghost assigned stephengillie and zachcarp Dec 3, 2022
stephengillie
stephengillie reviewed Dec 5, 2022
View reviewed changes
...fests/g/GitHub/GitCredentialManager/2.0.877.50119/GitHub.GitCredentialManager.installer.yaml

PackageIdentifier: GitHub.GitCredentialManager
PackageVersion: 2.0.877.50119
Installers:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Installers:
Dependencies:
PackageDependencies:
- PackageIdentifier: Git.Git
Installers:

@stephengillie stephengillie mentioned this pull request Feb 8, 2023
Closed
2 tasks
@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Dec 8, 2022
@stephengillie
Copy link
Collaborator

Dependencies not added.

@denelon denelon mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie left review comments

Assignees

@zachcarp zachcarp

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Executable-Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zejjnt @wingetbot @stephengillie @zachcarp