lint: Escape backslash separators #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change escapes the backslash separator between `ServerName\ShareName` and `DomainName\UserName`. Because this was not escaped, it was causing one of the `<i>` tags to show, instead of the slash itself.
|
@Chris-Johnston : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
Thanks for your contribution, I've merged your changes and they should be live soon. |
Contributor
Author
|
Thanks @lastnameholiu ! I was going to go back and fix this same issue in the CredUIPromptForCredentialsA doc too, I guess I'll just do it in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change escapes the backslash separator between
ServerName\ShareNameandDomainName\UserName. Because this was not escaped, it was causing one of the<i>tags to show, instead of the slash itself.TODO:
Escape the same backslashes in the CredUIPromptForCredentialsA docWill do in another PR