EnumResourceNames/Ex: Add remark about resource name lifetime for the callback #1957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docs do not specify if it's safe to use the returned resource name outside of the callback (e.g. storing it in a variable for later comparison). Since the whole PE module is loaded in memory, a feasible implementation could return a pointer to the string inside the mapped image, so it's not "obvious" that a single buffer is reused for all callback invocations.
From my testing, the functions reuse a single internal buffer where the resource name is copied (the pointer passed for string resource names is the same in all invocations). I'm adding a remark that describes this, and also clarifies that the callee does not need to free the pointed-to memory at the end of the callback.