Unit testing empty access token

Author: nikithauc

spec/core/Client.ts

@@ -101,6 +101,45 @@ describe("Client.ts", () => {
 			const response = await client.api("me").get();
 			assert.equal(response, responseBody);
 		});
+
+		it("Should throw error in case the access token is undefined", async () => {
+			try {
+				const options = {
+					defaultVersion: "v1.0",
+					debugLogging: true,
+					authProvider: (done) => {
+						done(null, getTokenFunction());
+					},
+				};
+
+				const getTokenFunction = (): string => {
+					return undefined;
+				};
+				const client = Client.init(options);
+				const res = await client.api("/test").get();
+			} catch (error) {
+				assert.isDefined(error.body);
+			}
+		});
+
+		it("Should throw error in case the access token is empty", async () => {
+			try {
+				const options = {
+					defaultVersion: "v1.0",
+					debugLogging: true,
+					authProvider: (done) => {
+						done(null, getTokenFunction());
+					},
+				};
+				const getTokenFunction = (): string => {
+					return "";
+				};
+				const client = Client.init(options);
+				const res = await client.api("/test").get();
+			} catch (error) {
+				assert.isDefined(error.body);
+			}
+		});
 	});
 
 	describe("init", () => {

src/CustomAuthenticationProvider.ts

@@ -9,6 +9,7 @@
  * @module CustomAuthenticationProvider
  */
 
+import { GraphError } from "./browser";
 import { AuthenticationProvider } from "./IAuthenticationProvider";
 import { AuthProvider } from "./IAuthProvider";
 
@@ -48,7 +49,7 @@ export class CustomAuthenticationProvider implements AuthenticationProvider {
 					resolve(accessToken);
 				} else {
 					if (!error) {
-						reject("Access token cannot be undefined or empty");
+						error = new GraphError(-1, "Access token cannot be undefined or empty.");
 					}
 					reject(error);
 				}

src/GraphErrorHandler.ts

@@ -59,7 +59,7 @@ export class GraphErrorHandler {
 	 */
 	private static constructErrorFromResponse(error: any, statusCode: number): GraphError {
 		if (!error.error) {
-			const graphError = new GraphError(statusCode, "SDK failed to send the request");
+			const graphError = new GraphError(statusCode, "Microsoft Graph JavaScript Client SDK came across an error while processing the request");
 			graphError.body = error;
 			return graphError;
 		}