This repository was archived by the owner on Sep 10, 2021. It is now read-only.
User to aggregatemetric notification #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 4, 2016 15:30
Applied fixes from StyleCI
| CREATE INDEX "tracker_aggregate_metric_spec_branch" ON "tracker_aggregate_metric_spec" ("branch"); | ||
|
|
||
| CREATE TABLE IF NOT EXISTS "tracker_user2aggregate_metric_spec" ( | ||
| "id" serial PRIMARY KEY, |
There was a problem hiding this comment.
This is counter to our general convention of <table_name>_id.
There was a problem hiding this comment.
Does the MySQL table have a primary key? If not, this is correct.
|
Other than the nits (which may be illegitimate as @jamiesnape suggests), LGTM. |
It has a primary compound key Looking at this more carefully, I don't have the corresponding unique compound indices in pgsl and sqlite. Perhaps the way forward is to
Thoughts? |
|
I guess whatever we normally do in our |
Ahem. I'll follow |
|
@cpatrick PTAL. This changeset is small since your last checkpoint. |
|
LGTM. |
mgrauer
pushed a commit
that referenced
this pull request
Mar 8, 2016
…tification User to aggregatemetric notification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpatrick PTAL.
The backend to setting up aggregate metric notifications. Some of it anyway.