This repository was archived by the owner on Sep 10, 2021. It is now read-only.
User aggregatemetric notification ui #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrauer
force-pushed
the
user_aggregatemetric_notification_ui
branch
from
6a8dbd4 to
55d9549
Compare
|
Rebased, and ready for review. |
mgrauer
changed the title
| Add a user to be alerted<br/> | ||
| <div class='alertUserSearch'> | ||
| <input type='text' id='addAlertUserSearch' value='' autocomplete='off' | ||
| autocorrect='off' autocapitalize='off'/> |
There was a problem hiding this comment.
I don't get it. This was copypasta from elsewhere in Midas, btw.
There was a problem hiding this comment.
I associate these as fields added to inputs that make things behave better on mobile browsers. That's all.
|
LGTM (plus one snarky comment). |
mgrauer
pushed a commit
that referenced
this pull request
Mar 9, 2016
…ication_ui User aggregatemetric notification ui
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually done, but I'll WIP it until #201, which this is based on, is merged. I'll rebase this at that point to clearly show that it only includes 2 commits.