This repository was archived by the owner on Sep 10, 2021. It is now read-only.
Aggregregate metrics on all branches #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied fixes from StyleCI
Applied fixes from StyleCI
Applied fixes from StyleCI
* Remove getDistinctBranchesForMetricName from TrendModel. * Fix bad ordering query in SubmissionModel.
Applied fixes from StyleCI
Applied fixes from StyleCI
* origin/master: Add branch and metric textarea to user alerts UI Add branch name to aggregate metric notification email Add warning for definition edit of Tracker AMS
Applied fixes from StyleCI
This also uncovered some implementation issues. Hurray tests and thanks to @mgrauer for writing them!
Applied fixes from StyleCI
Applied fixes from StyleCI
mgrauer
changed the title
|
|
added 3 commits
April 13, 2016 15:12
mgrauer
changed the title
| /** @var Tracker_AggregateMetricNotificationDao $aggregateMetricNotificationDao */ | ||
| $aggregateMetricNotificationDao = $aggregateMetricNotificationModel->load($aggregateMetricNotificationId); | ||
| $userDao = $apihelperComponent->getUser($args); | ||
| if ($aggregateMetricSpecModel->policyCheck($aggregateMetricNotificationDao->getAggregateMetricSpec(), $userDao, MIDAS_POLICY_WRITE) === false) { |
There was a problem hiding this comment.
Here's where the READ policy change should be
|
GET now requires READ |
|
This should be ok to merge from a conflict perspective. |
|
Closing this PR as all new commits were merged in #231. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpatrick PTAL
This includes all the commits of #202. I can give you a demo tomorrow.
The behavior change is to split the aggregate metrics from notifications. Metrics defined by an aggregate metric spec will be calculated on all submissions. Notifications will only be set by an aggregate metric notification, which defines a threshold and a branch, and can have users linked to it who will be notified when a metric is over threshold.