This repository was archived by the owner on Sep 10, 2021. It is now read-only.
Metric spec definition ui immutable #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
April 13, 2016 02:03
Applied fixes from StyleCI
Applied fixes from StyleCI
|
Code LGTM. |
|
I had some time in a meeting and simplified the code and made it more consistent with the current UI. Can you take another look? |
|
continues to lgtm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #228. Makes the AMS definition immutable from the UI.
Also allows the user to confirm a deletion of an AMS, since that could be easily clicked by accident and has the potential to delete many saved, calculated aggregate metrics.
@cpatrick PTAL. I can demo this to you at some point--it'll keep.