fix where we specify dependencies #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is no way to specify that _run_tests_ depends on cleanup, so our best bet is to make sure that cleanup has few dependencies and gets run early. This was only exposed by the documentation fix in #13
|
(See #13 (comment)) edit: Sounds reasonable. But the cleanup could be run too early, if only the coverage target is invoked. Maybe include a build step to the README? Is this the intended use? |
|
I had experimented with an additional dependency of run_tests* to make sure cleanup is called before executing the tests (not throwing away the just gathered results): jschleicher@4b2a2ce But as far as I remember there was a problem, that the run_tests * target does not always exist... |
|
After quite a bit of testing, I think this is also resolved by #18 (or at least we maybe have a different problem to deal with). |
|
#18 Looks great, thank you! I'm eager to try it out :-) Thank you! |
knorth55
added a commit
to knorth55/code_coverage
that referenced
this pull request
Aug 7, 2023
append include python directories to default lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is no way to specify that run_tests
depends on cleanup, so our best bet is to make sure that
cleanup has few dependencies and gets run early. This was
only exposed by the documentation fix in #13