Remove support of 1.2 and 1.3 #723
Conversation
|
@davidanthoff since I made some changes to simplify the tests now that we only include v1.4, any tests with 1.2 and 1.3 will fail so I removed those from the yml files for CI. I think the Github UI is a little broken because it shows below that it's waiting for reports on those, but in reality they're never going to be run as shown by the Details page. So you will probably need your magic powers to override the merge later. |
| # @test y_vec[begin] == time_dim_val[:,2,2][begin] | ||
| # @test y_mat[begin,1] == time_dim_val[:,:,2][begin,1] | ||
| # @test y_mat[begin,2] == time_dim_val[:,:,2][begin,2] | ||
| # begin syntax is deprecated v1.0.0 - v1.3.0, so enable only works for post v1.4.0 |
There was a problem hiding this comment.
this will now fail v1.2 and v1.3 tests, could move to a separate PR if that's an issue
| else | ||
| @test_throws ErrorException add_comp!(m, A, after=:B) | ||
| end | ||
| @test_throws ErrorException add_comp!(m, A, after=:B) |
There was a problem hiding this comment.
this will now fail v1.2 and v1.3 tests, could move to a separate PR if that's an issue
| else | ||
| @test_throws ErrorException add_comp!(my_model, testcomp2, after=:testcomp3) | ||
| end | ||
| @test_throws ErrorException add_comp!(my_model, testcomp2, after=:testcomp3) |
There was a problem hiding this comment.
this will now fail v1.2 and v1.3 tests, could move to a separate PR if that's an issue
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 79.95% 80.14% +0.19%
==========================================
Files 38 38
Lines 2883 2881 -2
==========================================
+ Hits 2305 2309 +4
+ Misses 578 572 -6
Continue to review full report at Codecov.
|
#721