-
Notifications
You must be signed in to change notification settings - Fork 35
Remove support of 1.2 and 1.3 #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,13 +46,7 @@ last_A = 2150 | |
|
||
m = Model() | ||
set_dimension!(m, :time, years) | ||
|
||
# ArgumentError in v1.0-v1.2, ErrorException in v1.3 | ||
if(VERSION < v"1.3.0") | ||
@test_throws ArgumentError add_comp!(m, A, after=:B) | ||
else | ||
@test_throws ErrorException add_comp!(m, A, after=:B) | ||
end | ||
@test_throws ErrorException add_comp!(m, A, after=:B) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this will now fail v1.2 and v1.3 tests, could move to a separate PR if that's an issue |
||
|
||
add_comp!(m, A) | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -611,15 +611,14 @@ y_mat = TimestepMatrix{VariableTimestep{y_years}, Int, 1}(time_dim_val[:,:,2]) | |
|
||
@test eltype(x_vec) == eltype(y_vec) == eltype(y_vec) == eltype(y_mat) == eltype(time_dim_val) | ||
|
||
# TODO begin syntax is depreacated v1.0.0 - v1.3.0, so enable the tests after | ||
# after we disable Julia versions below v1.4.0 | ||
|
||
# @test x_vec[begin] == time_dim_val[:,1,1][begin] | ||
# @test x_mat[begin,1] == time_dim_val[:,:,1][begin,1] | ||
# @test x_mat[begin,2] == time_dim_val[:,:,1][begin,2] | ||
# @test y_vec[begin] == time_dim_val[:,2,2][begin] | ||
# @test y_mat[begin,1] == time_dim_val[:,:,2][begin,1] | ||
# @test y_mat[begin,2] == time_dim_val[:,:,2][begin,2] | ||
# begin syntax is deprecated v1.0.0 - v1.3.0, so enable only works for post v1.4.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this will now fail v1.2 and v1.3 tests, could move to a separate PR if that's an issue |
||
|
||
@test x_vec[begin] == time_dim_val[:,1,1][begin] | ||
@test x_mat[begin,1] == time_dim_val[:,:,1][begin,1] | ||
@test x_mat[begin,2] == time_dim_val[:,:,1][begin,2] | ||
@test y_vec[begin] == time_dim_val[:,2,2][begin] | ||
@test y_mat[begin,1] == time_dim_val[:,:,2][begin,1] | ||
@test y_mat[begin,2] == time_dim_val[:,:,2][begin,2] | ||
|
||
@test x_vec[end] == time_dim_val[:,1,1][end] | ||
@test x_mat[end,1] == time_dim_val[:,:,1][end,1] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will now fail v1.2 and v1.3 tests, could move to a separate PR if that's an issue