Port some features shared by all frameworks to UAST #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those issues don't sound too major to me. Looking forward to looking at this. |
RedNesto
force-pushed
the
203/uast-framework-commons
branch
from
424d051 to
d7d21ec
Compare
RedNesto
force-pushed
the
203/uast-framework-commons
branch
from
d7d21ec to
ddec3a1
Compare
DenWav
approved these changes
Apr 10, 2021
There was a problem hiding this comment.
Sorry for leaving this for so long.
Just looked at this in depth and I'm really impressed, it looks great and it's still pretty clean, while greatly expanding mcdev's feature support. Very well done!
I'll leave this open just in case there's more you want to do on it - I see you mentioned this in #846, so not sure if you want to do that separately or update this PR. I'm marking this as approved, so go ahead and merge it when you're ready.
|
Great :) I just pushed a commit to fix a Ktlint violation. I'll fix the other issue separately, getting this PR merged as-is is already good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely:
I target 2020.3 because it has the most complete UAST implementation for all major JVM language plugins; I ran into some major issues with previous versions (some even affected Java code.)
I encountered a few minor problems so far:
Annotations & color line markers do not work in Groovy, but are fine in Java, Kotlin and Scala. I suspect this is a bug in the Groovy plugin and given the language is not really used in modding AFAIK I will ignore this problem.
The Scala plugin doesn't provide a
UastCodeGenerationPluginso we can't replace color constants. Vector-based SpongeColors do not work either because of an NPE in their PsiElementFactory.