Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F5 debug display: Reformat and remove some information #6125

Merged
merged 1 commit into from Jul 16, 2017
Merged

F5 debug display: Reformat and remove some information #6125

merged 1 commit into from Jul 16, 2017

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Jul 12, 2017

For consistency return to 'FPS =', add comma before FPS.
Remove 'R' from 'range_all' as may be re-keymapped.
Remove inconsistent brackets from 'range_all'.
Change 'v_range' to 'view_range'.
Add 'pos = ' before co-ordinates.
Add spaces around '=' in yaw display.
Remove brackets from around 'yaw' and 'seed'.
Move 'pointing_at' to 3rd line.
Remove 'param1' (0 for all solid nodes and unreadable for light sources due to
light bank encoding).
Remove file name of pointed node top tile (this also removes the need to get
ContentFeatures for the node, slightly improving performance).
Replace quotes around node data with brackets, looks better and more consistent.

Add 'guitext3' for third line.
Use 'setVisible' for all 3 lines to control the setting of each text rectangle.
Improve logic of 3rd line to only run code it needs to depending on whether
pointing data is avaialble and whether node is not 'ignore' and not 'unknown'.
/////////////

screenshot_20170712_135051

screenshot_20170712_135101

^ 1024x576 which is a rough minimum.

Addresses #6110
Node names can get quite long but now the 3rd line will never run off-screen.
Returns FPS line to consistent form as requested by @sfan5 here https://github.com/minetest/minetest/pull/6031/files#r123721561
Below, current behaviour at 1024x576, 'pointing_at' tile information is missing from 2nd line:

screenshot_20170712_132659

@paramat paramat added @ Client / Audiovisuals WIP The PR is still being worked on by its author and not ready yet. labels Jul 12, 2017
@rubenwardy
Copy link
Member

No one is going to play minetest in 800x600, you should base your measurements off 1024x768 at least (which is a good base for old computers). Most computers these days are 1920x1080. Minetest being 800x600 just makes the window easier to drag/manage

@paramat
Copy link
Contributor Author

paramat commented Jul 12, 2017

I'm sure some play with 800x600 to increase performance, but not many.
It looks a little sloppy if the default screen size has information running off the screen. Perhaps we can get around this by increasing the default screen width to a much nicer looking 16:9 ratio like 1024x576?

So anyway i won't worry about the run off for now. So not WIP.

@paramat paramat added WIP The PR is still being worked on by its author and not ready yet. and removed WIP The PR is still being worked on by its author and not ready yet. labels Jul 12, 2017
@paramat
Copy link
Contributor Author

paramat commented Jul 12, 2017

WIP to consder the use of brackets on 2nd line, they're needed for co-ordinates but maybe they can be removed from the rest?

@paramat
Copy link
Contributor Author

paramat commented Jul 12, 2017

Updated screenshots to 1024 width. There is space to keep 'range_all' now, does anyone find it useful? It's known from screen messages on press.
I might as well keep it, will re-add.
Will add 'pos = ' to co-ordinates.

@Calinou
Copy link
Member

Calinou commented Jul 12, 2017

Perhaps we can get around this by increasing the default screen width to a much nicer looking 16:9 ratio like 1024x576?

I made a pull request for changing the default resolution to 1024×600 (which is not 16:9, though) a while ago, but it was never merged.

Feel free to change the default resolution to 1024×576, it sounds fine to me.

It may also be a good thing to increase the default font size ("normal" and "mono" fonts).

@paramat paramat changed the title F5 debug: Remove some information, move 'pointing at' to 3rd line F5 debug display: Reformat and remove some information Jul 12, 2017
@paramat paramat removed the WIP The PR is still being worked on by its author and not ready yet. label Jul 12, 2017
@paramat
Copy link
Contributor Author

paramat commented Jul 12, 2017

Updated with stated changes, see new commit message for details.
Cleaner and more descriptive with many brackets removed for clarity but brackets used around node data instead of quotes.
New screenshots in first post.
No longer WIP.

For consistency return to 'FPS =', add comma before FPS.
Remove 'R' from 'range_all' as may be re-keymapped.
Remove inconsistent brackets from 'range_all'.
Change 'v_range' to 'view_range'.
Add 'pos = ' before co-ordinates.
Add spaces around '=' in yaw display.
Remove brackets from around 'yaw' and 'seed'.
Move 'pointing_at' to 3rd line.
Remove 'param1' (0 for all solid nodes and unreadable for light sources due to
light bank encoding).
Remove file name of pointed node top tile (this also removes the need to get
ContentFeatures for the node, slightly improving performance).
Replace quotes around node data with brackets, looks better and more consistent.

Add 'guitext3' for third line.
Use 'setVisible' for all 3 lines to control the setting of each text rectangle.
Improve logic of 3rd line to only run code it needs to depending on whether
pointing data is avaialble and whether node is not 'ignore' and not 'unknown'.
@paramat
Copy link
Contributor Author

paramat commented Jul 12, 2017

Screen dimensions PR #6126 makes debug information fit on the screen.

@paramat
Copy link
Contributor Author

paramat commented Jul 13, 2017

Found the original PRs #1677 #1853 The top tile is shown because it was difficult to get the tile actually pointed at.
I don't feel the tile information is very useful, as it is usually the same as the nodename or something very similar, and texture names can get quite long, using up screen space on the new 3rd line.
So i still feel it is best to remove the tile information.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a third debug line is fine. If it would fit into two lines with the reduced information, even better.

@paramat
Copy link
Contributor Author

paramat commented Jul 15, 2017

Looking at one of those screenshots it looks like the 3rd line will maybe just fit on a 1024 width for 'dirt with rainforest litter', but longer nodenames would run offscreen.

@SmallJoker
Copy link
Member

@paramat I guess that's good enough. Not many node names longer than that.

@nerzhul nerzhul merged commit d4cc49e into minetest:master Jul 16, 2017
@Fixer-007
Copy link
Contributor

There is regression introduced in this, chat text is blocked by debug text:
default

@paramat
Copy link
Contributor Author

paramat commented Jul 17, 2017

Ugh sorry, other messages too, will fix today.

@paramat paramat deleted the debug branch July 19, 2017 00:30
Eurybot pushed a commit to MT-Eurythmia/minetest that referenced this pull request Jul 25, 2017
For consistency return to 'FPS =', add comma before FPS.
Remove 'R' from 'range_all' as may be re-keymapped.
Remove inconsistent brackets from 'range_all'.
Change 'v_range' to 'view_range'.
Add 'pos = ' before co-ordinates.
Add spaces around '=' in yaw display.
Remove brackets from around 'yaw' and 'seed'.
Move 'pointing_at' to 3rd line.
Remove 'param1' (0 for all solid nodes and unreadable for light sources due to
light bank encoding).
Remove file name of pointed node top tile (this also removes the need to get
ContentFeatures for the node, slightly improving performance).
Replace quotes around node data with brackets, looks better and more consistent.

Add 'guitext3' for third line.
Use 'setVisible' for all 3 lines to control the setting of each text rectangle.
Improve logic of 3rd line to only run code it needs to depending on whether
pointing data is avaialble and whether node is not 'ignore' and not 'unknown'.
@JRottm JRottm mentioned this pull request Aug 20, 2017
9 tasks
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 11, 2019
For consistency return to 'FPS =', add comma before FPS.
Remove 'R' from 'range_all' as may be re-keymapped.
Remove inconsistent brackets from 'range_all'.
Change 'v_range' to 'view_range'.
Add 'pos = ' before co-ordinates.
Add spaces around '=' in yaw display.
Remove brackets from around 'yaw' and 'seed'.
Move 'pointing_at' to 3rd line.
Remove 'param1' (0 for all solid nodes and unreadable for light sources due to
light bank encoding).
Remove file name of pointed node top tile (this also removes the need to get
ContentFeatures for the node, slightly improving performance).
Replace quotes around node data with brackets, looks better and more consistent.

Add 'guitext3' for third line.
Use 'setVisible' for all 3 lines to control the setting of each text rectangle.
Improve logic of 3rd line to only run code it needs to depending on whether
pointing data is avaialble and whether node is not 'ignore' and not 'unknown'.
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
For consistency return to 'FPS =', add comma before FPS.
Remove 'R' from 'range_all' as may be re-keymapped.
Remove inconsistent brackets from 'range_all'.
Change 'v_range' to 'view_range'.
Add 'pos = ' before co-ordinates.
Add spaces around '=' in yaw display.
Remove brackets from around 'yaw' and 'seed'.
Move 'pointing_at' to 3rd line.
Remove 'param1' (0 for all solid nodes and unreadable for light sources due to
light bank encoding).
Remove file name of pointed node top tile (this also removes the need to get
ContentFeatures for the node, slightly improving performance).
Replace quotes around node data with brackets, looks better and more consistent.

Add 'guitext3' for third line.
Use 'setVisible' for all 3 lines to control the setting of each text rectangle.
Improve logic of 3rd line to only run code it needs to depending on whether
pointing data is avaialble and whether node is not 'ignore' and not 'unknown'.
luk3yx pushed a commit to luk3yx/minetest that referenced this pull request Mar 6, 2019
For consistency return to 'FPS =', add comma before FPS.
Remove 'R' from 'range_all' as may be re-keymapped.
Remove inconsistent brackets from 'range_all'.
Change 'v_range' to 'view_range'.
Add 'pos = ' before co-ordinates.
Add spaces around '=' in yaw display.
Remove brackets from around 'yaw' and 'seed'.
Move 'pointing_at' to 3rd line.
Remove 'param1' (0 for all solid nodes and unreadable for light sources due to
light bank encoding).
Remove file name of pointed node top tile (this also removes the need to get
ContentFeatures for the node, slightly improving performance).
Replace quotes around node data with brackets, looks better and more consistent.

Add 'guitext3' for third line.
Use 'setVisible' for all 3 lines to control the setting of each text rectangle.
Improve logic of 3rd line to only run code it needs to depending on whether
pointing data is avaialble and whether node is not 'ignore' and not 'unknown'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants