set cache default values as documented #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aead
force-pushed
the
fix-cache-defaults
branch
2 times, most recently
from
60d4037 to
00e0416
Compare
This commit fixes a two bugs in the cache configuration logic.
1. KES now applies a default cache configuration as documented here:
https://github.com/minio/kes/blob/master/server-config.yaml#L147
2. KES now removes entry from the offline cache if no offline cache
expiry is specified. Before, KES used to not clear the cache if
no offline cache configuration has been specified (docs claim that
KES disables offline caching without explicit configuration).
Signed-off-by: Andreas Auernhammer <github@aead.dev>
aead
force-pushed
the
fix-cache-defaults
branch
from
00e0416 to
4c61cba
Compare
allanrogerr
approved these changes
Apr 12, 2024
ramondeklein
pushed a commit
to ramondeklein/kes
that referenced
this pull request
Apr 17, 2024
This commit fixes a two bugs in the cache configuration logic.
1. KES now applies a default cache configuration as documented here:
https://github.com/minio/kes/blob/master/server-config.yaml#L147
2. KES now removes entry from the offline cache if no offline cache
expiry is specified. Before, KES used to not clear the cache if
no offline cache configuration has been specified (docs claim that
KES disables offline caching without explicit configuration).
Signed-off-by: Andreas Auernhammer <github@aead.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the cache configuration logic. As documented in https://github.com/minio/kes/blob/master/server-config.yaml#L147 KES is supposed to apply a default KES configuration when none is provided.
With this commit, a KES server (started via the
kes servercommand) applies a default cache config, if none is set. Thekes/kesconfpackage does not implement the default configuration since we don't want to modify the user input at this level.