Return consistent outputs for put_object/fput_object #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatello
approved these changes
Feb 23, 2017
docs/API.md
Outdated
| ```py | ||
|
|
||
| # Put an object 'myobject' with contents from '/tmp/otherobject'. | ||
| # Put an object 'myobject' with contents from '/tmp/otherobject', prints hex md5sum of the object if uploaded successfully. |
There was a problem hiding this comment.
This is not accurate - for multipart objects the etag != hex m5sum
docs/API.md
Outdated
|
|
||
| import os | ||
| # Put a file with default content-type. | ||
| # Put a file with default content-type, upon success prints hex md5sum of the object. |
There was a problem hiding this comment.
This is not accurate - for multipart objects the etag != hex m5sum
harshavardhana
force-pushed
the
fix-fapi
branch
from
47ede3d to
4379b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally also return the stat info of the original
object for fget_object.
Fixes #480
Fixes #481