mc: use functional tests from mc repo #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
suggested changes
Sep 20, 2017
build/mc/install.sh
Outdated
| @@ -20,3 +20,5 @@ MC_VERSION="RELEASE.2017-06-15T03-38-43Z" | |||
| test_run_dir="$MINT_RUN_CORE_DIR/mc" | |||
| $WGET --output-document="${test_run_dir}/mc" "https://dl.minio.io/client/mc/release/linux-amd64/mc.${MC_VERSION}" | |||
| chmod a+x "${test_run_dir}/mc" | |||
| $WGET --output-document="${test_run_dir}/functional-tests.sh" https://raw.githubusercontent.com/minio/mc/master/functional-tests.sh | |||
There was a problem hiding this comment.
functional tests should be pulled from specific mc release like other SDKs
This was referenced Sep 26, 2017
|
can you fix the branch conflicts? Can't pull docker image from travis. |
harshavardhana
requested changes
Sep 27, 2017
|
This PR can't be verified until next mc's release |
|
@harshavardhana @nitisht this PR is ready for review |
harshavardhana
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.