Fix mc logging and exit on first failure

[nitisht]

Fixes #154

[balamurugana]

PR #139 is pulling functional test of mc which is taken care in that.

[nitisht]

@balamurugana we need to release mint soon. Do you think #139 should be merged and be the part of mint first release?

[balamurugana]

@nitisht I am not saying we need to take/wait for #139 for the release

[kannappanr]

Value for error is missing double quotes

function log_failure() {
    function=$(python -c 'import sys,json; print(json.dumps(sys.stdin.read()))' <<<"$2")
    printf '{"name": "mc", "duration": "%d", "function": %s, "status": "FAIL", "error": %s}\n' "$1" "$function" "$3"
}

Within test_mirror_list_objects function, around line 362

if [ $rv -eq 0 ]; then 
        if  diff -bB <(ls "$MINT_DATA_DIR") <(./mc ls --json "${SERVER_ALIAS}/${bucket_name}" | jq -r .key ) > /dev/null; then
            function="delete_bucket"
            out=$(delete_bucket "$bucket_name") 
            rv=$?
        else
            rv=1
        fi
    fi

I see that the diff check is failing in my case. You will have to add sort to both the ls and mc command output and also redirect the output to /dev/null

Something like this

 if  diff -bB <(ls "$MINT_DATA_DIR" | sort) <(./mc ls --json "${SERVER_ALIAS}/${bucket_name}" | jq -r .key | sort ) > /dev/null; then

Also, I see that the buckets and objects are getting deleted only in the case of failure. Since, every test is creating a bucket, it is important to properly cleanup the buckets and objects.

[nitisht]

updated the PR @kannappanr

[kannappanr]

Similar to AWSCLI, we will modify the function name and args in a different PR. Otherwise LGTM

[deekoder]

is travis expected to fail?

[kannappanr]

Shellcheck generates a warning on ls and sort in the following line of code

if  diff -bB <(ls "$MINT_DATA_DIR" | sort) <(./mc ls --json "${SERVER_ALIAS}/${bucket_name}" | jq -r .key | sort) > /dev/null; then

this can be replaced by find like this

if  diff -bB <(find "$MINT_DATA_DIR" -type f -printf "%f\n" | sort) <(./mc ls --json "${SERVER_ALIAS}/${bucket_name}" | jq -r .key | sort) > /dev/null; then

[nitisht]

Updated the PR @kannappanr @deekoder