Skip to content

Conversation

dvaldivia
Copy link
Collaborator

Screen Shot 2021-09-03 at 12 32 40 PM

Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com

@dvaldivia dvaldivia self-assigned this Sep 3, 2021
adfost
adfost previously approved these changes Sep 3, 2021
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with the active prop inside TableActionButton.tsx:67, please either remove the prop or add it in ShareIcon.tsx

Beside of that works & looks good

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit b13b6db into minio:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants