Skip to content

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Sep 9, 2021

What does this do?

Fixes warnings in console for non used icons

Signed-off-by: Benjamin Perez benjamin@bexsoft.net

@bexsoft bexsoft self-assigned this Sep 9, 2021
@bexsoft bexsoft added dependency Dependency, DO NOT MERGE YET WIP This PR is WIP and cannot be merged yet labels Sep 9, 2021
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't need asset updates?

@dvaldivia
Copy link
Collaborator

@harshavardhana I think it's fine to skip assets since it's multiple separate PRs, we can do assets on the next PR after these 2, or the next release

@bexsoft
Copy link
Collaborator Author

bexsoft commented Sep 9, 2021

doesn't need asset updates?

Yes, It's still WIP, I will need to get #1017 merged as this one can break some parts of object browser

@bexsoft bexsoft force-pushed the warning-cleanup-new branch from 0ca2ac3 to c8b4283 Compare September 9, 2021 17:42
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft force-pushed the warning-cleanup-new branch from c8b4283 to 161d80b Compare September 9, 2021 17:48
@bexsoft bexsoft removed WIP This PR is WIP and cannot be merged yet dependency Dependency, DO NOT MERGE YET labels Sep 9, 2021
@dvaldivia dvaldivia merged commit 755e0b4 into minio:master Sep 9, 2021
@dvaldivia dvaldivia deleted the warning-cleanup-new branch September 9, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants