fix: leaking fd's large object uploads #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next work is to make this API fully streaming instead of using staging, we are currently bottlenecked by using ParseMultipartForm() approach and implement a full streaming approach. |
Fixes multiple things - Closes the local open files properly staged during multipart form upload. - Removes these files upon upload properly, otherwise we run out of disk space on /tmp/ due to staging of these objects.
harshavardhana
force-pushed
the
fix-multipart-form
branch
from
704a2e3 to
4a501e6
Compare
dvaldivia
approved these changes
Sep 10, 2021
|
@harshavardhana yeah, we should disallow multiple file uploads together, and do one at a time via UI, so we can stream the file into MinIO |
Even multiple files stream is possible just has to be implemented properly. |
Alevsk
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multiple things
Closes the local open files properly staged
during multipart form upload.
Removes these files upon upload properly, otherwise
we run out of disk space on /tmp/ due to staging
of these objects.