fix: TLS issues with console #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-spa
branch
from
e6db038 to
cc57c4a
Compare
Merged
This PR fixes two bugs one is - incorrect termination of the HTTP connections when the resource URL path is `/`, since `/` doesn't exist we should never call h.ServeHTTP() instead should be directly served from public assets. - add SSLHostFunc() such that if the Hostname is empty redirection is not empty and this value is handled properly when redirecting from 9090 to 9443.
harshavardhana
force-pushed
the
fix-spa
branch
from
780cdb6 to
82a614f
Compare
dvaldivia
approved these changes
Sep 14, 2021
Alevsk
approved these changes
Sep 14, 2021
|
i think make assets was missed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs one is
incorrect termination of the HTTP connections
when the resource URL path is
/, since/doesn't exist we should never call h.ServeHTTP()
instead should be directly served from public assets.
add SSLHostFunc() such that if the Hostname is empty
redirection is not empty and this value is handled
properly when redirecting from 9090 to 9443.