PVC Events API #1409
Merged
PVC Events API #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfost
requested review from
Alevsk,
dvaldivia,
prakashsvmx,
bexsoft and
jinapurapu
dvaldivia
requested changes
Jan 18, 2022
There was a problem hiding this comment.
A lot of these changes seem to be removing things recently added by the update to swagger v0.28.0 make sure you are generating the new stubs with the latest swagger
➜ swagger version
version: v0.28.0
commit: 48a66e4bdbcde02c8c6c95ff9a08f64fe40b1b50
(base) console git:(update-swagger) ✗
|
please also rebase |
dvaldivia
requested changes
Jan 19, 2022
There was a problem hiding this comment.
I'm getting a 404 when calling the API
➜ curl 'http://localhost:9090/api/v1/namespaces/ns-1/tenants/new-tenant/pvcs/data0-new-tenant-pool-0-3/events' \
-X 'GET' \
-H 'Cookie: token=AYz9aZn1XU3ojFK798xSG6qbO9E2ZVoozMOKN2vV9egRFbc/KUu/K8YE9Jf+GKgVkhADcQJdh0/G95OWAaQR6VDvJin55Q=='
response
{"code":404,"message":"path /api/v1/namespaces/ns-1/tenants/new-tenant/pvcs/data0-new-tenant-pool-0-3/events was not found"}%
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API for getting events of PVCs