Skip to content

Tweaks to registration. #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Jan 26, 2022

Screen Shot 2022-01-26 at 9 54 03 AM

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Alevsk
Alevsk previously approved these changes Jan 26, 2022
bexsoft
bexsoft previously approved these changes Jan 26, 2022
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cniackz
Copy link
Collaborator

cniackz commented Jan 26, 2022

Hello Daniel, I am testing the branch in my computer.
The page is loading but I see console error that maybe is not related.
But just wonder if we can repair here or in another PR...

Screen Shot 2022-01-26 at 1 13 57 PM

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@dvaldivia dvaldivia merged commit c89f5a7 into minio:master Jan 26, 2022
@Alevsk Alevsk deleted the tweaks-registration branch January 26, 2022 18:28
@cniackz
Copy link
Collaborator

cniackz commented Jan 26, 2022

Nice, re-tested and console error is gone:

Screen Shot 2022-01-26 at 1 29 41 PM

Thanks Daniel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants