remove quota FIFO support #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
remove-fio
branch
from
2ba0425 to
efe3b84
Compare
harshavardhana
force-pushed
the
remove-fio
branch
from
6c00699 to
6f75492
Compare
|
@harshavardhana is this also gone from the server? |
Yes it will be gone but need this PR first. |
prakashsvmx
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Tested:
- On Update of Existing Bucket with FIFO Quota
- On new Bucket creation
- Update of Bucket Quota post creation
Changes look good to me. 👍
Few UX Suggestions which can be addressed later:
Quota_type in body should be one of [hard]error message can be updated When editing an existing FIFO Quota and saving without selecting the Type. ( or we can default to hard always )Quota Typeselection can be removed as it would be the default , and Quota label can be " Quota Size"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.