Update tenant creation credentials JSON #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinapurapu
requested review from
harshavardhana,
Alevsk,
cniackz,
adfost,
dvaldivia and
bexsoft
harshavardhana
requested changes
Feb 11, 2022
jinapurapu
force-pushed
the
credentials_update
branch
from
2c39258 to
94efa64
Compare
harshavardhana
requested changes
Feb 12, 2022
There was a problem hiding this comment.
Are we not planning to change this for Service Accounts UI? @jinapurapu
harshavardhana
force-pushed
the
credentials_update
branch
from
6a2dee6 to
485c926
Compare
jinapurapu
force-pushed
the
credentials_update
branch
from
85839e3 to
2cfeb56
Compare
|
@harshavardhana this works on both regular |
👍🏽 |
harshavardhana
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do: Changes tenant creation credentials JSON output to the format :
{
"url" : "http://localhost:5000",
"accessKey" : "YJ0RI0F4R5HWY38MD873",
"secretKey" : "OHz5CT7xdMHiXnKZP0BmZ5P4G5UvWvVaxR8gljLG",
"api": "s3v4",
"path": "auto",
}
Addresses https://github.com/miniohq/engineering/issues/270