Support for deploying minio/console with IDP integration #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Jul 31, 2020
Comment on lines
+407
to
+444
| minInst.Spec.Env = append(minInst.Spec.Env, corev1.EnvVar{ | ||
| Name: "MINIO_IDENTITY_LDAP_SERVER_ADDR", | ||
| Value: userNameFormat, | ||
| }, corev1.EnvVar{ | ||
| Name: "MINIO_IDENTITY_LDAP_USERNAME_FORMAT", | ||
| Value: userNameFormat, | ||
| }, corev1.EnvVar{ | ||
| Name: "MINIO_IDENTITY_LDAP_USERNAME_SEARCH_FILTER", | ||
| Value: userSearchFilter, | ||
| }, corev1.EnvVar{ | ||
| Name: "MINIO_IDENTITY_LDAP_USERNAME_SEARCH_FILTER", | ||
| Value: userSearchFilter, | ||
| }, corev1.EnvVar{ | ||
| Name: "MINIO_IDENTITY_LDAP_GROUP_SEARCH_BASE_DN", | ||
| Value: groupSearchDN, | ||
| }, corev1.EnvVar{ | ||
| Name: "MINIO_IDENTITY_LDAP_GROUP_SEARCH_FILTER", | ||
| Value: groupSearchFilter, | ||
| }, corev1.EnvVar{ | ||
| Name: "MINIO_IDENTITY_LDAP_GROUP_NAME_ATTRIBUTE", | ||
| Value: groupNameAttribute, | ||
| }) | ||
|
|
||
| if tlsSkipVerify { | ||
| minInst.Spec.Env = append(minInst.Spec.Env, corev1.EnvVar{ | ||
| Name: "MINIO_IDENTITY_LDAP_TLS_SKIP_VERIFY", | ||
| Value: "on", | ||
| }) | ||
| } | ||
| if serverInsecure { | ||
| minInst.Spec.Env = append(minInst.Spec.Env, corev1.EnvVar{ | ||
| Name: "MINIO_IDENTITY_LDAP_SERVER_INSECURE", | ||
| Value: "on", |
There was a problem hiding this comment.
While this is okay for now, will make changes on the server codebase so that this is easily referenced and importable, such that any of these ENV changes console is not broken.
Alevsk
force-pushed
the
idp-integration
branch
3 times, most recently
from
91db800 to
8549941
Compare
dvaldivia
previously approved these changes
Aug 3, 2020
dvaldivia
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.