Skip to content

Conversation

dvaldivia
Copy link
Collaborator

No description provided.

@dvaldivia dvaldivia self-assigned this Aug 3, 2020
@kerneltime
Copy link

I guess console memory never goes more than 64 megs ? When listing buckets and keys how do we ensure that the memory footprint is within the min requested.

@dvaldivia
Copy link
Collaborator Author

@kerneltime we don't, we have not tested with a large enough number of buckets that would crash the system, and on regular k8s this request means we want at least 64Mi guaranteed, it's not a limit, so if exceeded it would not kill the pod.

if we had to list 500,000 buckets, then we would start taking 64MB with only the bucket names in string format in memory, but that's a pretty insane number of buckets, and a nice problem to have if someone comes with such problem.

@kerneltime
Copy link

We might get killed if the pod cannot take the spike from our minimum requested.. I understand that we have not specified a limit but just the floor..

@dvaldivia dvaldivia merged commit cd547e9 into minio:master Aug 3, 2020
@dvaldivia dvaldivia deleted the increase-logging-tenants branch August 3, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants