Skip to content

encrypt token session using aes-gcm if cpu support it or ChaCha20 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

encrypt token session using aes-gcm if cpu support it or ChaCha20 #248

merged 1 commit into from
Aug 18, 2020

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Aug 18, 2020 •
edited
Loading

  • adding associated data parameter for future use to encrypt/decrypt functions
  • Harsha's improvement to use binary encoding instead of json encoding

@Alevsk Alevsk self-assigned this Aug 18, 2020
harshavardhana
harshavardhana requested changes Aug 18, 2020
View reviewed changes
harshavardhana
harshavardhana requested changes Aug 18, 2020
View reviewed changes
@Alevsk
encrypt token session using aes-gcm if cpu support it or ChaCha20
b3bee7c 
Harsha's improvement to use binary encoding instead of json encoding
@Alevsk Alevsk requested a review from harshavardhana August 18, 2020 19:32
bexsoft
bexsoft approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit f880e39 into minio:master Aug 18, 2020
@Alevsk Alevsk deleted the aes-gcm-aead branch August 18, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft bexsoft approved these changes

@cesnietor cesnietor Awaiting requested review from cesnietor

@aead aead Awaiting requested review from aead

Assignees

@Alevsk Alevsk

Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alevsk @harshavardhana @dvaldivia @bexsoft