-
Notifications
You must be signed in to change notification settings - Fork 426
Fix download of large files in Console #2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix download of large files in Console #2773
Conversation
I found a memory problem while downloading a large file, to test this I did the following
|
on |
perhaps for Safari we can force a direct download? @reivaj05 |
@dvaldivia I believe we won't be able to set anonymous access header if we force a direct download, is that right? |
@reivaj05 when do we need to do that? :S |
@dvaldivia it's part of the existing code: https://github.com/minio/console/blob/master/portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/utils.ts#L54 |
…wnload-of-large-files
Added way to download directly in safari if file size is more than 4G |
…sole into fix-download-of-large-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PR with the following scenarios:
- Uploaded 5GB File, everything OK
- Downloaded File in Chrome, Need to find a way to display more constant batches for the progress bar as it updates only every 25%
- On Safari, the whole application freezes between batches and sometimes crashes once the download has been completed
- On Firefox Navigator Download manager & MinIO's object manager opens at the same time (not really an issue as current behavior opens Firefox manager after MinIO's object manager completes the download)
- On Opera same behavior as Firefox is observed
Tested on Chrome with 4G and 100G files ✅ |
@bexsoft i couldn't find a better way to display progress, current approach to get the chunks is @bexsoft @cesnietor i'm going to let safari browser handle the downloads directly instead of setting a limit because seems 4G files is still too much for safari to handle |
…wnload-of-large-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
portal-ui/src/screens/Console/ObjectBrowser/objectBrowserThunks.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo fixed
Fixes: #2760