Fixed subnet Health report upload #2927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinapurapu
requested review from
pjuarezd,
cniackz,
reivaj05,
cesnietor,
allanrogerr,
dvaldivia,
bexsoft and
dilverse
Fixed lint errors Fixed errors Removed unneded filename Removed unneded switch Fixed error, variable declarations and return gofumpt remove unneded else WIP find missing API to put in header Added functions to get apiKey from Subnet using license to generate auth headers for Subnet upload Added text prompting retry of failed report, cleanup Cleanup Cleanup simplified return
…ent before fetching from subnet
jinapurapu
force-pushed
the
fix_subnetupload
branch
from
3941632 to
14a5bd8
Compare
reivaj05
reviewed
Jul 14, 2023
reivaj05
previously approved these changes
Jul 19, 2023
bexsoft
requested changes
Jul 20, 2023
|
@jinapurapu how can I test this? seems I need to register my cluster but this is local. do you have some creds? please share privately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions to get API key from Subnet using license key, to correctly generate SUBNET upload headers, process Health report for upload, generic subnet upload.
Also adds UI improvements on HealthInfo screen to display error if empty Health report is returned, prompt user to retry failed reports.