fix health report upload error #3275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjalshireesh
commented
Mar 27, 2024
anjalshireesh
requested review from
harshavardhana,
bexsoft,
jinapurapu and
prakashsvmx
jinapurapu
previously approved these changes
Mar 27, 2024
prakashsvmx
reviewed
Mar 28, 2024
prakashsvmx
previously approved these changes
Apr 1, 2024
After moving the processing of uploaded health report to background, SUBNET now doesn't return the cluster URL in response of health upload. This was resulting in error being shown on the UI even when upload to SUBNET was succesful. Fix this by not expecting the cluster URL in response, and instead linking to the deployments page URL (/health) after succesful upload. Also start using exposed functions from mc instead of duplicating the logic in console.
jinapurapu
approved these changes
Apr 1, 2024
prakashsvmx
approved these changes
Apr 3, 2024
bexsoft
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving the processing of uploaded health report to background, SUBNET now doesn't return the cluster URL in response of health upload.
This was resulting in error being shown on the UI even when upload to SUBNET was succesful.
Fix this by not expecting the cluster URL in response, and instead linking to the deployments page URL (/health) after succesful upload.
Also start using exposed functions from mc instead of duplicating the logic in console.