Skip to content

Conversation

cesnietor
Copy link
Collaborator

@cesnietor cesnietor commented Apr 25, 2024

No description provided.

@cesnietor cesnietor self-assigned this Apr 25, 2024
@cesnietor cesnietor marked this pull request as ready for review April 25, 2024 00:04
kaankabalak
kaankabalak previously approved these changes Apr 25, 2024
@kaankabalak kaankabalak self-requested a review April 25, 2024 00:14
@kaankabalak
Copy link
Contributor

@cesnietor Not sure if it's a blocker, but the React vulnerability check seems to be failing with the following:

Run yarn audit --groups dependencies
yarn audit v1.22.22
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ critical      │ Formidable arbitrary file upload                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ formidable                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=3.2.[4](https://github.com/minio/console/actions/runs/8824893639/job/24228205249?pr=3313#step:4:5)                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ superagent                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ superagent > formidable                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/1097147                     │
└───────────────┴──────────────────────────────────────────────────────────────┘
1 vulnerabilities found - Packages audited: 41[5](https://github.com/minio/console/actions/runs/8824893639/job/24228205249?pr=3313#step:4:6)
Severity: 1 Critical
Done in 1.19s.
Error: Process completed with exit code 16.

@cesnietor
Copy link
Collaborator Author

@kaankabalak yes I'll fix that first

@cesnietor cesnietor marked this pull request as draft April 25, 2024 00:16
@kaankabalak
Copy link
Contributor

@kaankabalak yes I'll fix that first

Thanks @cesnietor 👍

@kaankabalak kaankabalak dismissed their stale review April 25, 2024 00:19

Vulnerability check is not passing

@cesnietor cesnietor marked this pull request as ready for review April 25, 2024 00:31
@cesnietor
Copy link
Collaborator Author

fixed and rebased @kaankabalak

@harshavardhana harshavardhana merged commit 6625d54 into minio:master Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants