Skip to content

Adding Bucket Policies UI to ViewBucket.tsx #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Conversation

adfost
Copy link
Contributor

@adfost adfost commented Mar 26, 2021

No description provided.

dvaldivia
dvaldivia previously approved these changes Mar 26, 2021
Alevsk
Alevsk previously approved these changes Mar 26, 2021
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove that line, beside of that, looks good


const PolicyActions = [
{ type: "view", onClick: viewAction },
{ type: "delete", onClick: confirmDeleteEvent, sendOnlyId: true },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this action as this onClick function is to delete an event

Suggested change
{ type: "delete", onClick: confirmDeleteEvent, sendOnlyId: true },

@adfost adfost dismissed stale reviews from Alevsk and dvaldivia via 642918d March 26, 2021 16:01
@dvaldivia dvaldivia merged commit 23b3283 into minio:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants