Skip to content

Add Tenant Health Details #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2021

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Jun 1, 2021

Screen Shot 2021-06-01 at 4 40 17 PM

Screen Shot 2021-06-01 at 4 40 24 PM

Screen Shot 2021-06-01 at 4 48 59 PM

Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com

@dvaldivia dvaldivia self-assigned this Jun 1, 2021
@dvaldivia dvaldivia requested a review from belvid June 1, 2021 23:50
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@dvaldivia dvaldivia force-pushed the add-tenant-health-status branch from 1dd5354 to b825c5c Compare June 1, 2021 23:50
@dvaldivia
Copy link
Collaborator Author

@belvid we need an official Green, Yellow, Red shade, I think we do have an official Red for errors, but not the other two

bexsoft
bexsoft previously approved these changes Jun 2, 2021
@belvid
Copy link

belvid commented Jun 2, 2021

Here you go boys:

G: #32c787
Y: #ffb300
R: #f75155

@dvaldivia
Copy link
Collaborator Author

@belvid we already use #dc1f2e for red, which is a little more red than #f75155, should we make that the default?

@dvaldivia
Copy link
Collaborator Author

Screen Shot 2021-06-02 at 2 08 33 PM

Screen Shot 2021-06-02 at 2 08 24 PM

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@belvid
Copy link

belvid commented Jun 2, 2021

Yes, please use #f75155 globally.

Copy link
Contributor

@Alevsk Alevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit f183604 into minio:master Jun 2, 2021
@Alevsk Alevsk deleted the add-tenant-health-status branch June 3, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants