Pod Events #807

adfost · 2021-06-10T22:17:23Z

pkg/acl/endpoints.go

portal-ui/src/screens/Console/Console.tsx

bexsoft · 2021-06-11T03:42:49Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

-        setErrorSnackMessage(err);
-      });
-  }, [tenantNamespace, tenantName, podName, setErrorSnackMessage]);
+    loadInfo();


Please use the content of loadInfo function inside this effect and remove the // eslint-disable-next-line react-hooks/exhaustive-deps. I think this change shouldn't go

Please review this

bexsoft · 2021-06-11T03:43:09Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

-    api
-      .invoke(
-        "GET",
-        `/api/v1/namespaces/${tenantNamespace}/tenants/${tenantName}/pods/${podName}`
-      )
-      .then((res: string) => {
-        setLogLines(res.split("\n"));
-      })
-      .catch((err) => {
-        setErrorSnackMessage(err);
-      });
-  }, [tenantNamespace, tenantName, podName, setErrorSnackMessage]);


Please use the content of loadInfo function inside this effect and remove the // eslint-disable-next-line react-hooks/exhaustive-deps. I think this change shouldn't go

bexsoft · 2021-06-11T03:43:54Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

            {" > "}
            <Link
-              to={`/namespaces/${tenantNamespace}/tenants/${tenantName}`}
+              to={`/namespaces/${match.params["tenantNamespace"]}/tenants/${match.params["tenantName"]}`}


Please use tenantNamespace & tenantName variables

bexsoft · 2021-06-11T03:44:09Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

              className={classes.breadcrumLink}
            >
-              {tenantName}
+              {match.params["tenantName"]}


please use tenantName var

bexsoft · 2021-06-11T03:44:24Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

+              {match.params["tenantName"]}
            </Link>
-            {` > Pods > ${podName}`}
+            {` > Pods > ${match.params["podName"]}`}


Please use podName var

bexsoft · 2021-06-11T03:46:06Z

restapi/admin_tenants.go

 	retval := []*models.TenantPod{}
 	for _, pod := range pods.Items {
-		var restarts int64
+		var restarts int64 = 0


Please check gofmt checks

dvaldivia · 2021-06-12T00:09:42Z

Can you attach a screenshot of how it looks?

dvaldivia · 2021-06-12T00:20:59Z

Can you sort the events in ascending order (older on top, newer at the bottom) and group them?

dvaldivia

Please fix all the warnings introduced on PodDetails.tsx

src/screens/Console/Tenants/TenantDetails/PodDetails.tsx
  Line 19:8:    'get' is defined but never used                      @typescript-eslint/no-unused-vars
  Line 31:3:    'Button' is defined but never used                   @typescript-eslint/no-unused-vars
  Line 32:3:    'IconButton' is defined but never used               @typescript-eslint/no-unused-vars
  Line 33:3:    'Menu' is defined but never used                     @typescript-eslint/no-unused-vars
  Line 34:3:    'MenuItem' is defined but never used                 @typescript-eslint/no-unused-vars
  Line 48:8:    'history' is defined but never used                  @typescript-eslint/no-unused-vars
  Line 49:10:   'LogMessage' is defined but never used               @typescript-eslint/no-unused-vars
  Line 50:10:   'IPolicyItem' is defined but never used              @typescript-eslint/no-unused-vars
  Line 51:10:   'TabPanel' is defined but never used                 @typescript-eslint/no-unused-vars
  Line 167:10:  'selectedTab' is assigned a value but never used     @typescript-eslint/no-unused-vars
  Line 167:23:  'setSelectedTab' is assigned a value but never used  @typescript-eslint/no-unused-vars
  Line 168:19:  'setLoading' is assigned a value but never used      @typescript-eslint/no-unused-vars
  Line 169:10:  'log' is assigned a value but never used             @typescript-eslint/no-unused-vars

dvaldivia · 2021-06-14T17:17:54Z

While doing kubectl get event I'm seeing the last event, 4 minutes ago but the UI is showing 6 hours ago

➜ k get event -n ns-2 --field-selector involvedObject.name=asdzxczxc-pool-0-3
LAST SEEN   TYPE      REASON             OBJECT                   MESSAGE
4m41s       Warning   FailedScheduling   pod/asdzxczxc-pool-0-3   0/5 nodes are available: 1 node(s) had taint {node-role.kubernetes.io/master: }, that the pod didn't tolerate, 1 node(s) were unschedulable, 3 node(s) had volume node affinity conflict.

The problem is also present in pod listing, where the age of pods is not aligned with theUI

➜ k get pods -n ns-1
NAME                                     READY   STATUS    RESTARTS   AGE
asdasd-console-5c5f969756-ghd98          1/1     Running   0          12d
asdasd-log-0                             1/1     Running   0          12d
asdasd-log-search-api-657dffbcb8-9ln74   1/1     Running   3          12d
asdasd-pool-0-0                          1/1     Running   0          7m3s
asdasd-pool-0-1                          1/1     Running   0          12d
asdasd-pool-0-2                          1/1     Running   0          12d
asdasd-pool-0-3                          1/1     Running   0          12d
asdasd-prometheus-0                      2/2     Running   0          12d

dvaldivia · 2021-06-14T18:03:23Z

swagger.yml

+    properties:
+      namespace:
+        type: string
+      lastseen:


rename this to last_seen
Change type to integer of format: int64

dvaldivia · 2021-06-14T18:03:59Z

restapi/admin_tenants.go

+	for i := 0; i < len(events.Items); i++ {
+		retval = append(retval, &models.EventListElement{
+			Namespace: events.Items[i].Namespace,
+			Lastseen:  fmt.Sprintf("%d", events.Items[i].LastTimestamp.Unix()),


the .Unix() already returns int64, store the integer that way

dvaldivia · 2021-06-14T23:01:13Z

portal-ui/src/screens/Console/Account/Account.tsx

-  const [selectedServiceAccount, setSelectedServiceAccount] = useState<
-    string | null
-  >(null);
+  const [selectedServiceAccount, setSelectedServiceAccount] =


this needs to be formatted with prettier 2.3.1

bexsoft · 2021-06-15T03:46:00Z

yarn.lock

@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


Please remove this file

bexsoft · 2021-06-15T03:52:02Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

-        setErrorSnackMessage(err);
-      });
-  }, [tenantNamespace, tenantName, podName, setErrorSnackMessage]);
+    loadInfo();


Please review this

dvaldivia · 2021-06-15T17:47:04Z

I'm getting events that are not related to the pod in question

dvaldivia · 2021-06-15T17:35:03Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

+        `/api/v1/namespaces/${tenantNamespace}/tenants/${tenantName}/pods/${podName}`
+      )
+      .then((res: string) => {
+        setLog(res);


remove setLog since log is not used

dvaldivia · 2021-06-15T18:50:20Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

        setEvent(res);
      })
      .catch((err) => {
-        setErrorSnackMessage(err);


if you remove setErrorSnackMessage you don't display an error should there be one

dvaldivia · 2021-06-15T19:07:42Z

consoleAdmin.json

@@ -0,0 +1,16 @@
+{


please remove this file

dvaldivia · 2021-06-17T00:13:28Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

  setErrorSnackMessage,
 }: ITenantDetailsProps) => {
+  const [loading, setLoading] = useState<boolean>(false);
+  const [log, setLog] = useState<string>("");


remove unused lines

dvaldivia · 2021-06-17T00:30:18Z

portal-ui/src/screens/Console/Tenants/TenantDetails/PodDetails.tsx

+                { label: "Event Type", elementKey: "event_type" },
+                { label: "Reason", elementKey: "reason" },
+              ]}
+              isLoading={false}


do show a loading indicator

dvaldivia

don't delete md files

…od_events

adfost force-pushed the pod_events branch from 80c9170 to 14ba452 Compare June 10, 2021 22:20

bexsoft requested changes Jun 11, 2021

View reviewed changes

bexsoft assigned adfost Jun 11, 2021

adfost force-pushed the pod_events branch from 73ac63a to 225b56a Compare June 11, 2021 20:07

dvaldivia requested changes Jun 12, 2021

View reviewed changes

dvaldivia requested changes Jun 14, 2021

View reviewed changes

dvaldivia requested review from Alevsk and jinapurapu June 14, 2021 18:04

dvaldivia requested changes Jun 14, 2021

View reviewed changes

bexsoft requested changes Jun 15, 2021

View reviewed changes

adfost force-pushed the pod_events branch from bf78f2d to 49a7eb9 Compare June 15, 2021 17:54

dvaldivia requested changes Jun 15, 2021

View reviewed changes

dvaldivia requested changes Jun 17, 2021

View reviewed changes

dvaldivia previously approved these changes Jun 17, 2021

View reviewed changes

adfost dismissed dvaldivia’s stale review via 6bbc3a0 June 17, 2021 19:04

Pod Events

aebb4d1

adfost force-pushed the pod_events branch from 6bbc3a0 to aebb4d1 Compare June 17, 2021 19:05

Merge branch 'master' into pod_events

d0ca75b

dvaldivia requested changes Jun 17, 2021

View reviewed changes

Adam Stafford added 3 commits June 17, 2021 13:46

restoring files

4ff6f67

merging Merge branch 'pod_events' of github.com:adfost/console into p…

8900457

…od_events

restoring files

3ca4222

dvaldivia previously approved these changes Jun 17, 2021

View reviewed changes

make assets

5ffc5d8

adfost dismissed dvaldivia’s stale review via 5ffc5d8 June 17, 2021 21:10

dvaldivia approved these changes Jun 17, 2021

View reviewed changes

bexsoft approved these changes Jun 17, 2021

View reviewed changes

Merge branch 'master' into pod_events

cf7cdbd

dvaldivia merged commit 09503ed into minio:master Jun 17, 2021

		@@ -0,0 +1,4 @@
		# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

Pod Events #807

Pod Events #807

Uh oh!

Conversation

adfost commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dvaldivia commented Jun 12, 2021

Uh oh!

dvaldivia commented Jun 12, 2021

Uh oh!

dvaldivia left a comment

Choose a reason for hiding this comment

Uh oh!

dvaldivia commented Jun 14, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dvaldivia commented Jun 15, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dvaldivia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adfost commented Jun 10, 2021 •

edited

Loading