Skip to content

Enforced error type #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2021
Merged

Enforced error type #904

merged 1 commit into from
Jul 29, 2021

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Jul 28, 2021

requires #903

What does this do?

  • Fixes some issues with new error handling and some old functions
  • Enforces error typing in all invoke requests

@bexsoft bexsoft self-assigned this Jul 28, 2021
@bexsoft bexsoft added dependency Dependency, DO NOT MERGE YET needed High Priority UI User Interface labels Jul 28, 2021
adfost
adfost previously approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@adfost adfost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft removed the dependency Dependency, DO NOT MERGE YET label Jul 28, 2021
@dvaldivia dvaldivia merged commit efae5f6 into minio:master Jul 29, 2021
@bexsoft bexsoft deleted the errors-fixing branch November 12, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alevsk Alevsk Alevsk approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

@adfost adfost adfost left review comments

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@bexsoft bexsoft

Labels
needed High Priority UI User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bexsoft @Alevsk @adfost @dvaldivia