Jannes #6
Merged
Jannes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-ROS-dependent functions and files
…ions of gymnasiun and stable_baselines3
* added `additional_config` to `readPANTHERparams` and `getPANTHERparamsAsCppStruct` to support overwriting parameters loaded from `panther.yaml`
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR in the
imitationrepo is directly related to this PRThis PR introduces a new structure to some of the repositories features and also some new functionality.
The original intention was to allow for the
deep_pantherexpert (ExpertPolicy.py) to be used without the catkin build system.For this reason, utility functions on the C++ side (
panther/includeandpanther/src) were split into separate filesros_utilsandros_timerfor specific ROS utilities andutilsandtimerfor features not dependent on ROS.Includes were adjusted so that ROS specific functionalities are now only included when absolutely necessary.
The same was done on the Python side. Utilities were split into separate files to allow for more precise import statements and reduce overhead.
This now allows us to use the expert as a standalone library.
An example on how this can be done can be found here.
New functionalities that were added are:
main.mand passing adimkwarg to theExpertPolicyconstructor.total_timeof the expert trajectoryAlso we switched from
gymtogymnasium.