Skip to content

Commit 34a0b04

Browse files
jkachelshanbady
andauthored
Updates icons to use Remixicons where they don't already (#1157)
* Swapping the icons on the Browse by Topics (and elsewhere since this is a shared component) and on Departments List * Swapping out the rest of the icons that were marked * Removing a bunch of SVG icons that we don't need anymore (they're all Remixicons now) * forgot one * swapping out last few icons * Swapping icon on Learning Resource Card * Figured these two out so swapping - these may need to change though * Explicitly adding a data-testid to the grab handles on the card templates The Mui icons seem to do that by default but the Remixicons don't so the test was failing. * switching some more icons * some more remixicon replacements * adding remixicon as dependency * fixing icon * replacing external link icon * fixing visual issue * swapping out more remixicons * updating yarn locklfile * updating package json * making some more replacements * replacing some more icons * replacing more icons * fixing size * replacing storybook references to mui * removing material icon package * removing final refs to mui icon --------- Co-authored-by: shankar ambady <ambady@mit.edu> Co-authored-by: Shankar Ambady <shanbady@gmail.com>
1 parent 4231211 commit 34a0b04

File tree

44 files changed

+159
-289
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+159
-289
lines changed

frontends/.eslintrc.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,6 @@ function restrictedImports({ paths = [], patterns = [] } = {}) {
154154
message: "Please use @faker-js/faker/locale/en instead.",
155155
allowTypeImports: true,
156156
},
157-
{
158-
name: "@mui/icons-material",
159-
message: "Please use @mui/icons-material/<ICON_NAME> instead.",
160-
allowTypeImports: true,
161-
},
162157
{
163158
name: "@mui/material",
164159
message: "Please use @mui/material/<COMPONENT_NAME> instead.",

frontends/mit-open/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
"dependencies": {
6161
"@ebay/nice-modal-react": "^1.2.13",
6262
"@mitodl/course-search-utils": "^3.1.4",
63-
"@mui/icons-material": "^5.15.15",
6463
"@remixicon/react": "^4.2.0",
6564
"@sentry/react": "^7.57.0",
6665
"@tanstack/react-query": "^4.36.1",

frontends/mit-open/public/images/navdrawer/certificate.svg

Lines changed: 0 additions & 6 deletions
This file was deleted.

frontends/mit-open/public/images/navdrawer/courses.svg

Lines changed: 0 additions & 10 deletions
This file was deleted.

frontends/mit-open/public/images/navdrawer/departments.svg

Lines changed: 0 additions & 8 deletions
This file was deleted.

frontends/mit-open/public/images/navdrawer/free.svg

Lines changed: 0 additions & 5 deletions
This file was deleted.

frontends/mit-open/public/images/navdrawer/learning_materials.svg

Lines changed: 0 additions & 6 deletions
This file was deleted.

frontends/mit-open/public/images/navdrawer/new.svg

Lines changed: 0 additions & 12 deletions
This file was deleted.

frontends/mit-open/public/images/navdrawer/pathways.svg

Lines changed: 0 additions & 7 deletions
This file was deleted.

frontends/mit-open/public/images/navdrawer/popular.svg

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)