fix tests

Author: ChristopherChudzicki

frontends/ol-test-utilities/src/mocks/nextNavigation.test.ts

@@ -1,4 +1,4 @@
-import { renderHook } from "@testing-library/react"
+import { act, renderHook } from "@testing-library/react"
 import { nextNavigationMocks } from "./nextNavigation"
 import mockRouter from "next-router-mock"
 import { createDynamicRouteParser } from "next-router-mock/dynamic-routes"
@@ -51,4 +51,24 @@ describe("Mock Navigation", () => {
     const { result } = renderHook(() => nextNavigationMocks.useParams())
     expect(result.current).toEqual({ id: "bar", other: "baz" })
   })
+
+  test("router.push", () => {
+    mockRouter.useParser(createDynamicRouteParser(["x"]))
+    mockRouter.setCurrentUrl("/dynamic/bar/baz?a=1&b=2")
+    const { result } = renderHook(() => nextNavigationMocks.useRouter())
+    act(() => {
+      result.current.push("/dynamic/foo", { scroll: false })
+    })
+    expect(mockRouter.asPath).toBe("/dynamic/foo")
+  })
+
+  test("router.replace", () => {
+    mockRouter.useParser(createDynamicRouteParser(["x"]))
+    mockRouter.setCurrentUrl("/dynamic/bar/baz?a=1&b=2")
+    const { result } = renderHook(() => nextNavigationMocks.useRouter())
+    act(() => {
+      result.current.replace("/dynamic/foo", { scroll: false })
+    })
+    expect(mockRouter.asPath).toBe("/dynamic/foo")
+  })
 })

frontends/ol-test-utilities/src/mocks/nextNavigation.ts

@@ -37,6 +37,21 @@ const convertObjectToUrlParams = (obj: ParsedUrlQuery): [string, string][] =>
       : [[key, value] as [string, string]],
   )
 
+/**
+ * memoryRouter is a mock for the older pages router
+ * this file adapts it for the app router
+ * but older router had 3-arg push and replace (url, as, options)
+ * new router has 2-arg (url, options).
+ *
+ * Our application code may call the 2-arg version which 2nd arg as options,
+ * which causes problems for the mock. Let's just limit the mock to the first
+ * argument. The options don't really make sense in a JSDom environment anyway.
+ */
+const originalPush = mocks.memoryRouter.push
+const originalReplace = mocks.memoryRouter.replace
+mocks.memoryRouter.push = (url) => originalPush(url)
+mocks.memoryRouter.replace = (url) => originalReplace(url)
+
 export const nextNavigationMocks = {
   ...mocks,
   notFound: jest.fn(),