Fixing broken bug cover dialog in case no cover is avaiable

[daschuer]

https://bugs.launchpad.net/bugs/1823199

[uklotzde]

I'm not able to reproduce the bug that has been flagged as critical. How do I open the cover art window for tracks with no cover art?

[ronso0]

works as it should.

interesting: I never noticed the issue as the (empty) cover window wouldn't open every time. Sometimes it took 3-4 attempts to open it, and on other occassions I could see a window being opened for a fraction of a second but it disappeared right away. Also the (empty) cover would open with completely different sizes.. strange. but fixed now

[uklotzde]

I'm not qualified to verify this fix without being able to reproduce the reported issue.

[uklotzde]

Is this the intended behavior?

• The cover art window keeps displaying the last available cover when switching to next/prev track, even if those tracks have no cover art
• A small, empty window is opened for tracks without cover art

This is behavior is actually inconsistent and the content of the window does not always reflect the properties of the selected track.

[daschuer]

This PR is only a quick fix to restore the 2.1 state. There is not working code fragments that changes the cover when selecting a new track. But this looks more like a copy and paste left over from the cover widget. We have already a bug for your described behavior: https://bugs.launchpad.net/mixxx/+bug/1807450 I think we can do it later.

[uklotzde]

The behavior was more inconsistent before the change and I'm not able to reproduce any bug. I have no objections against the code, but I'm still waiting for someone to explain to me why we should merge this minor change???

[uklotzde]

Does it depend on the Qt version?

[daschuer]

The issue here is a regression from the Qt5 dead lock fix #1849

[uklotzde]

One last try: How can I reproduce the bug to to verify this fix??

[daschuer]

Use an effected Os (Ubuntu Xenial is known), click on the empty cover cover art widget and see the GUI skin shine through the cover window. Click on close (x) but nothing happens.

[uklotzde]

I'm not able to open the cover art window for tracks without cover art on Fedora 29 / Qt 5.11 The window is automatically closed as soon as trying to select the cover of a track without cover art. The status quo works as expected and this fix makes it worse. Sorry, but I can't make an informed decision on how to handle this PR Retested with 2.2: The cover art window is not updated when changing the track selection. But the window is closed as soon as selecting clicking on empty cover art.

[uklotzde]

Retested again: I'm now able to open multiple (at least 2) cover art windows from the deck and the properties dialog at once? Only a minor issue.

The cover art window opened from a deck is automatically updated when loading another track, but not when changing the track selection within the property dialog. This (inconsistent) behavior seems to be unchanged after testing various use cases with different versions.

Since the behavior already seems to be slightly inconsistent it's ok to merge this PR if it fixes a serious issue.

[daschuer]

Yes, this cover window really need some love. Let's track the remaining issues in this bug:
https://bugs.launchpad.net/bugs/1807450

[daschuer]

Since you have not discovered regressions we could merge this now.

[daschuer]

Ups ... this should go to 2.2.1 as well. I will cherry pick this commit upstream.

[uklotzde]

Done.

[daschuer]

Thank you :-)