Cppcheck found some issues. Solved some of them. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Member variables `ControlDoublePrivate::m_trackType` and `ControlDoublePrivate::m_trackFlags` was not initialized in the constructor. - `SoundSourceProxy::ParseHeader`: return `OK` instead of `0`. - `TrackInfoObject::parse`: omitted implicit cast. - `TrackCollection`: added references to arguments in methods `getTrackSource...` - `chromaprinter.cpp`: Memory leak: `pData` (return without freeing `pData`). - In `GLSLWaveformRendererSignal::createFrameBuffers` was strange expression: `m_framebuffer->isValid() && m_framebuffer->isValid()`. - Lots of postfix ++/-- changed to prefix form.
| @@ -51,7 +51,7 @@ class BaseSqlTableModel : public QAbstractTableModel, public TrackModel { | |||
| bool initialized() const { return m_bInitialized; } | |||
| int getTrackId(const QModelIndex& index) const; | |||
| void search(const QString& searchText, const QString& extraFilter=QString()); | |||
| void setSearch(const QString& searchText, const QString extraFilter=QString()); | |||
| void setSearch(const QString& searchText, const QString& extraFilter=QString()); | |||
|
Check it please. I corrected all issues. |
|
LGTM, thank you @troyane! |
daschuer
added a commit
that referenced
this pull request
Jul 5, 2013
Cppcheck found some issues. Solved some of them. And fixed typo in GLSLWaveformRendererSignal::createFrameBuffers
Merged
11 tasks
Swiftb0y
pushed a commit
to Swiftb0y/mixxx
that referenced
this pull request
Nov 3, 2019
more edge cases
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
update footer copyright to 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControlDoublePrivate::m_trackTypeandControlDoublePrivate::m_trackFlagswas not initialized in theconstructor.
SoundSourceProxy::ParseHeader: returnOKinstead of0.TrackInfoObject::parse: omitted implicit cast.TrackCollection: added references to arguments in methodsgetTrackSource...chromaprinter.cpp: Memory leak:pData(return without freeingpData).GLSLWaveformRendererSignal::createFrameBufferswas strangeexpression:
m_framebuffer->isValid() && m_framebuffer->isValid().