-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loading custom sound config with '--sound-config' argument #4859
Conversation
9ddca62
to
b35ba96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting into reviewable commits. lgtm for me so far.
I think this is good enough to be mergd (if a second reviewer doesn't spot issues, of course). The preferences / startup UI integration is a bit more elaborate and I'm unsure I find time to finish that soonish, so I'll do it another branch. |
b35ba96
to
e5fe3b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM. Though I still need to do a manual test to verify.
Cool. I didn't do too many tests myself yet. With an arg config it shouldn't even matter if soundconfig.xml exists or not. |
Merge? |
Just a suggestion (not blocking merge or something), but if you can't specify full paths anyway, why not just dictate a naming scheme for the sake of shorter command lines? For example, instead of:
we could use:
And mixxx creates the filename from the name automatically? |
Sure, that makes sense. |
When reworking and simplifying #4862 it turned out that all the file(name) handling should rather happen in SoundManager, thus I suspend this one. Actually, dealing with filenames in general and in particular legacy |
I'm closing this. Sound config via command line is part of #4862 now |
Thanks for the review @Swiftb0y |
first step to resolve https://bugs.launchpad.net/mixxx/+bug/1516035
This allows loading a custom sound config via
--sound-config config_file.xml
. For now this is restricted to files inside the settings dir.If the argument not added or the passed file is not readable, default
soundconfig.xml
is used.Note: the given config file (command line or default) is used for all read/write operations in the current session, i.e. if you change your config those changes will be stored in your custom sound config.
Thus, the workflow currently goes like this:
Create sound profile
soundconfig.xml
and rename to something likesoundconfig_DDJ-SB3_NIAudio8.xml
Load sound profile
mixxx --sound-config soundconfig_DDJ-SB3_NIAudio8.xml
I post-poned adding a profile selector to Preferences > Sound Hardware since that is more elaborate than I first thought. It's mainly getting the UX right, but also some flaws in current DlgPrefSound become obvious when dealing with profiles for the entire page (e.g. some settings are applied instantly).