Skip to content

Conversation

@nickroberts
Copy link

In order to keep angular's code html5 validated, we should use the data- attribute prefix.

This allows us to get the appName based on these prefixes (take from angular's source).

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.1%) to 97.895% when pulling 41eb795 on nickroberts:master into 99f20e6 on mjt01:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 98.947% when pulling b7183da on nickroberts:master into 99f20e6 on mjt01:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0cd694a on nickroberts:master into 99f20e6 on mjt01:master.

@nickroberts
Copy link
Author

This resolves #40

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8c39788 on nickroberts:master into 99f20e6 on mjt01:master.

@michaeltaranto
Copy link
Owner

Sorry it's taken so long to look at this, would be great to have this PR broken into smaller discrete PRs. It will make the intent a lot clearer and the PRs easier to digest. Thanks

@michaeltaranto
Copy link
Owner

Closing based on lack of activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants