Skip to content

fix: handle quantized tie-embedding for Gemma3Text #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

fix: handle quantized tie-embedding for Gemma3Text #372

merged 1 commit into from
Aug 18, 2025

Conversation

jiwoong-choi
Copy link

Gemma3TextModel.santize method can now handle quantized tie-embedding.

fix: handle quantized tie-embedding for Gemma3Text
abc1eec 
Gemma3TextModel.santize method can now handle quantized tie-embedding.
davidkoski
davidkoski approved these changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davidkoski davidkoski merged commit 3557601 into ml-explore:main Aug 18, 2025
4 checks passed
@davidkoski davidkoski mentioned this pull request Aug 18, 2025
Closed
@jiwoong-choi jiwoong-choi deleted the patch-1 branch August 19, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkoski davidkoski davidkoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiwoong-choi @davidkoski