Skip to content

fix: handle quantized tie-embedding for Gemma3Text #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

fix: handle quantized tie-embedding for Gemma3Text #372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Libraries/MLXLLM/Models/Gemma3Text.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,10 @@ public class Gemma3TextModel: Module, LLMModel {
}

if processedWeights["lm_head.weight"] == nil {
if let embedWeight = processedWeights["model.embed_tokens.weight"] {
processedWeights["lm_head.weight"] = embedWeight
["weight", "scales", "biases"].forEach { key in
if let embedWeight = processedWeights["model.embed_tokens.\(key)"] {
processedWeights["lm_head.\(key)"] = embedWeight
}
}
}
return processedWeights
Expand Down