Various tweaks #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 21, 2020 15:59
Not-null Boolean columns fail this requirement, for example. <input type="checkbox" required> will not allow the page to be submitted until it is checked, despite an unchecked/falsey checkbox being valid data at the model level.
If specific fields are requested using the 'only' argument, the fields are now returned in that order. This makes use of ordered dictionary keys implemented in Python 3.7. Older versions of Python will continue to scramble the dictionary order as always.
|
Hey @timheap, yeah, can you break them up into separate PRs. A couple look obvious to do and I have comments and questions about the others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starting and publishing a fork, @mlenzen! I see you already pulled in one of my pull requests I submitted to upstream. Have a collection of other tweaks and improvements I've made recently to my local fork. Each commit is fairly isolated. If you would like me to break this apart into five pull requests so they can each be discussed separately, I can do that as well.