Blank QuerySelectField tweaks #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mx-moth
force-pushed
the
queryselectfield-blank-label
branch
from
ecb4fc6 to
3b387af
Compare
|
Pushed a fix for the broken test. For reference, the behaviour of having an empty choice as the first option if there is no default is how Django operates. You can read about it in the Django ModelChoiceField docs, and the code where they trigger this behaviour is in |
mx-moth
force-pushed
the
queryselectfield-blank-label
branch
from
3b387af to
c2af930
Compare
added 4 commits
February 7, 2020 11:41
Otherwise the first option is effectively the default. If users don't change anything, or don't notice the select, then the first option will be automatically selected.
mx-moth
force-pushed
the
queryselectfield-blank-label
branch
from
c2af930 to
05d133c
Compare
|
@timheap I'm a maintainer of the official wtforms-sqlalchemy project now. Can you move your PRs there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes that complement each other
Allow customizing blank value in QuerySelectField
Show blank option in QuerySelectField if nothing is selected
Otherwise the first option is effectively the default. If users don't
change anything, or don't notice the select, then the first option will
be automatically selected.
Set default "Select..." text for QuerySelectField.blank_label