Skip to content

Conversation

chharvey
Copy link

@chharvey chharvey commented Nov 16, 2017

this should fix #48

@coveralls
Copy link

coveralls commented Nov 16, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 589a310 on chharvey:patch-1 into 4787274 on mlucool:master.

@mlucool
Copy link
Member

mlucool commented Nov 16, 2017

Is there a reason to bump here? A fresh install should work as 1.3.2 was published.

@chharvey
Copy link
Author

A fresh install (deleting /node_modules & /package-lock.json and running npm install) does indeed solve #48 . Therefore this pull request is not absolutely necessary, but it is sufficient.

@mlucool
Copy link
Member

mlucool commented Nov 17, 2017

No need to bump this then. No one will get 1.3.1 anymore unless they explicitly asked of it. Closing.

@mlucool mlucool closed this Nov 17, 2017
@chharvey chharvey deleted the patch-1 branch November 17, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mkdirp seems to be used incorrectly

3 participants